proofcarryingdata / zupass

Zuzalu Passport
GNU General Public License v3.0
278 stars 72 forks source link

pretix sync: track product and event changes, add tests for this feature #317

Closed ichub closed 1 year ago

ichub commented 1 year ago

we need to be sure the following tests exist:

robknight commented 1 year ago

test for product that we're tracking no longer existing causing pretix sync to fail

I'm not sure that this does cause Pretix Sync to fail. We fetch all "items" for each event, and if an item was previously present but now is not, we soft-delete it.

We do have activeItemIDs and superuserItemIDs in the Pretix config, so perhaps we ought to be checking that items with those IDs do exist for the relevant events? Not sure if this should cause sync to fail, or should cause some kind of logging.