search

prooph / event-store-http-client

PHP 7.2 Event Store HTTP Client Implementation
BSD 3-Clause "New" or "Revised" License
25 stars 5 forks source link

Undefined variable: nextPosition in EventStoreHttpConnection.php #38

Open burzum opened 5 years ago

burzum commented 5 years ago

I'm getting this error message:

PHP Notice: Undefined variable: nextPosition in \vendor\prooph\event-store-http-client\src\Internal\EventStoreHttpConnection.php on line 632 PHP Stack trace:

Using this code, it's a slightly altered version of one of the examples from this repository: https://gist.github.com/burzum/da5787dde0a1ddcc45c9f03412babb5f

I'm using dev-masterand commit id is a658025e62904f6972c873f48acae6e77b852e2b

prolic commented 5 years ago

That's a known bug, the json parsing need to be redone.

On Tue, Jun 4, 2019, 10:36 Florian Krämer notifications@github.com wrote:

I'm getting this error message:

PHP Notice: Undefined variable: nextPosition in \vendor\prooph\event-store-http-client\src\Internal\EventStoreHttpConnection.php on line 632 PHP Stack trace:

Using this code, it's a slightly altered version of one of the examples from this repository: https://gist.github.com/burzum/da5787dde0a1ddcc45c9f03412babb5f

I'm using dev-masterand commit id is a658025 https://github.com/prooph/event-store-http-client/commit/a658025e62904f6972c873f48acae6e77b852e2b

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/prooph/event-store-http-client/issues/38?email_source=notifications&email_token=AADAJPBU3CMODKZHHJMN4V3PYZ4WTA5CNFSM4HS5ATZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXRQD6A, or mute the thread https://github.com/notifications/unsubscribe-auth/AADAJPHZXV2QPQ2CSXTP2GDPYZ4WTANCNFSM4HS5ATZA .

burzum commented 5 years ago

@prolic well, we're trying to build an application around the event store and @codeliner told us it is fine to use the event store in it's current state of development. But it doesn't look like this is the case with these issues? Is there any timeline for the refactoring of the response parsing?

I wouldn't mind to help with that but I would start by zero, I just started digging through the code of the event store and the client.

Is there any way I can get projections done with the current state of the library?

prolic commented 5 years ago

I'll try to give it a shot this weekend.

On Tue, Jun 4, 2019, 17:59 Florian Krämer notifications@github.com wrote:

@prolic https://github.com/prolic well, we're trying to build an application around the event store and @codeliner https://github.com/codeliner told us it is fine to use the event store in it's current state of development. But it doesn't look like this is the case with these issues? Is there any timeline for the refactoring of the response parsing?

I wouldn't mind to help with that but I would start by zero, I just started digging through the code of the event store and the client.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prooph/event-store-http-client/issues/38?email_source=notifications&email_token=AADAJPHIIRILAYV2QZPNLUTPY3QTJA5CNFSM4HS5ATZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW572DQ#issuecomment-498859278, or mute the thread https://github.com/notifications/unsubscribe-auth/AADAJPBMLSKMBD35OBRWWBDPY3QTJANCNFSM4HS5ATZA .

burzum commented 5 years ago

@prolic any news on this? If you haven't had the time to fix it yet, could you provide me enough info how you would like to get it re-written so that I can create a PR?

prolic commented 5 years ago

Sorry, didn't had the time to look into this. The problem is this class https://github.com/prooph/event-store-http-client/blob/master/src/Internal/ResolvedEventParser.php. There are some edge cases which it does not cover. I'm okay with whatever works and gets the job done correctly.

prolic commented 5 years ago

This nextPosition thingy is a bit problematic. See https://github.com/EventStore/EventStore/issues/1809. Reading from HEAD backwards after reaching end of stream might be a possible solution, but I don't have time to work on this right now.

Why don't you use the async implementation for your projections and use the HTTP client only for within web requests in a non-async environment?