prooph / event-store-http-client

PHP 7.2 Event Store HTTP Client Implementation
BSD 3-Clause "New" or "Revised" License
25 stars 5 forks source link

Fatal error in ProjectionDetails::__construct() #44

Closed enumag closed 5 years ago

enumag commented 5 years ago
TypeError:
Argument 9 passed to Prooph\EventStore\Projections\ProjectionDetails::__construct()
must be of the type string, null given, called in
/usr/app/vendor/prooph/event-store-http-client/src/Projections/ProjectionsManager.php
on line 522
prolic commented 5 years ago

Thanks, will look into it, or would you mind submitting a pull request?

On Thu, Sep 12, 2019, 09:23 Jáchym Toušek notifications@github.com wrote:

TypeError: Argument 9 passed to Prooph\EventStore\Projections\ProjectionDetails::__construct() must be of the type string, null given, called in /usr/app/vendor/prooph/event-store-http-client/src/Projections/ProjectionsManager.php on line 522

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/prooph/event-store-http-client/issues/44?email_source=notifications&email_token=AADAJPFVK7ZM6PPEFGUM4XDQJI7EZA5CNFSM4IWD3KYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HK7SW3Q, or mute the thread https://github.com/notifications/unsubscribe-auth/AADAJPE2WRPGKXLBFE6WR5DQJI7EZANCNFSM4IWD3KYA .

enumag commented 5 years ago

I'm not exactly sure what's the proper fix here. Also I don't know how it happened and can't reproduce it. I just found it in the logs.

prolic commented 5 years ago

Most likely it should be $entry['stateReason'] ?? '' @ line 506 - that's just a guess, but I can imagine the stateReason is empty when status is OK-ish.