search

prooph / event-store-http-client

PHP 7.2 Event Store HTTP Client Implementation
BSD 3-Clause "New" or "Revised" License
25 stars 5 forks source link

Common value objects #5

Closed enumag closed 5 years ago

enumag commented 5 years ago

For now I'll have to use both the HTTP client (for reading and appending to streams) and the TCP client (for connectToPersistentSubscription). So I need to be able to transform the RecordedEvent intances to real domain events in both modes.

It's easy to do of course, just slightly annoying since RecordedEvent is implemented in each client separately. There are quite a few other objects that appear in both of the libraries - it might make sense to share these between both libraries.

What do you think?

prolic commented 5 years ago

I was having the same thoughts. Maybe we can put common value objects in event-store v8?

prolic commented 5 years ago

/cc @codeliner

prolic commented 5 years ago

do