search

prooph / event-store

PHP 7.4 EventStore Implementation
http://getprooph.org
BSD 3-Clause "New" or "Revised" License
548 stars 73 forks source link

fix upcasting iterator #391

Closed prolic closed 4 years ago

prolic commented 4 years ago

resolves https://github.com/prooph/event-store/issues/389

also:

ping @marcuswinkler can you test against this branch?

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.09%) to 99.477% when pulling 0c7e522f8004dd84b428f85923beb47a25426084 on issue_389 into 654e0230a4fd6cb2466ac145171b5062547a7b21 on 7.x.

prolic commented 4 years ago

You can check the first and third commit for review only. The second one only updates the copyright and adds PHP 7.3 / 7.4 to travis.

marcuswinkler commented 4 years ago

Works fine now in our application. This solution also avoids having to touch pdo-event-store.

I just want to note that the count method on the UpcastingIterator is not very reliable, as the UpcastingIterator can produce multiple events for every event on the inner iterator.

prolic commented 4 years ago

Yes I know that, it's also mostly used for testing how far behind or up to date a projection is, is a few events difference won't be a problem.

Thanks for reporting it.

On Fri, Apr 17, 2020, 08:39 Marcus Winkler notifications@github.com wrote:

Works fine now in our application. This solution also avoids having to touch pdo-event-store.

I just want to note that the count method on the UpcastingIterator is not very reliable, as the UpcastingIterator can produce multiple events for every event on the inner iterator.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/prooph/event-store/pull/391#issuecomment-615221457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAJPAOKQBBMCGFSAJNQO3RNBEXZANCNFSM4MKLUVJQ .