search

prooph / event-store

PHP 7.4 EventStore Implementation
http://getprooph.org
BSD 3-Clause "New" or "Revised" License
548 stars 73 forks source link

Tests are missing #394

Closed Nek- closed 4 years ago

Nek- commented 4 years ago

Having some unit tests here could be great. WDYT?

Related to #393 (which would have been detected by a test)

prolic commented 4 years ago

A pull request is always welcome!

unixslayer commented 4 years ago

@prolic this was pretty confusing for me that changes made in this repository must be tested in another one. since this contains only interfaces and VOs, why is it separated from prooph/event-store-client? have you considered merging them together?

enumag commented 4 years ago

@unixslayer Interfaces are separated because there is a second implementation as well: https://github.com/prooph/event-store-http-client

unixslayer commented 4 years ago

@enumag thanks, didn't catch that.

evolic commented 4 years ago

So it seems that we can close this issue.