mark dropSubscription on CatchUpSubscription as internal

prooph / event-store

PHP 7.4 EventStore Implementation

http://getprooph.org

BSD 3-Clause "New" or "Revised" License

547 stars 74 forks source link

mark dropSubscription on CatchUpSubscription as internal #395

Closed prolic closed 4 years ago

coveralls commented 4 years ago

Coverage remained the same at 0.0% when pulling 50ccf3f2e8e30dd337c82c3ddb6dcad0442b31fa on dropSubscription into b2a838bf15ba45c3e9b89c0f583b90b98cdfb18b on master.

enumag commented 4 years ago

I think I'd rather drop it from the interfaces and make it protected... I can have a look if the logic can be refactored in a way to make it private.

prolic commented 4 years ago

Yeah, let's drop it.