Closed fritz-gerneth closed 3 years ago
Maybe we should switch to GitHub actions.
With PHP8 not working on Travis there is one apparent problem - other dependencies need to support PHP8 too. For the prooph/*
components this probably is realistic. The biggest concern is about phpunit though - the minimum version to use would be phpunit@9
- requiring php > 7.3
. That'd bump the version requirements of the prooph packages to 7.3 as well.
I see no problem to increase the minimum PHP version if needed. Maybe rector can be used to make the code automatically compatible if needed. But indeed, some work is needed.
Bump the minor version and make it a 7.5 version / branch then?
We already have version 7.5, so it will be 7.6. What do you think @codeliner @prolic ? Should we also increase the PHP minimum version to 7.4? I see no reason to support PHP 7.3 anymore in this new version.
good for me
Inherently this is blocked by https://github.com/prooph/php-cs-fixer-config/pull/8 / PHP-CS to support PHP8.
Note that php-cs-fixer (while it's not entirely ready to handle all PHP 8 features) no longer blocks installation under php 8. So in my opinion prooph/php-cs-fixer-config#8 can be merged now.
I've updated https://github.com/prooph/php-cs-fixer-config/pull/8 to support PHP ^7.1 || ^8.0
too.
Awesome. I'll update the prooph packages then :)
This should be good for review now :)
Thanks @fritz-gerneth, see here: https://github.com/prooph/event-store/releases/tag/v7.6.0
Travis is currently missing the PHP 8 option ( https://travis-ci.community/t/php-8-0-missing/10132/17 ) but should be available next weekChanges:
ProphesizeTrait
,prophesize
integration has been moved into its own packagephpspec/prophecy-phpunit
assertInternalType()
with new assertions ( old ones have been removed )assertRegExp
is deprecated and replaced@medium
that were running longer than 1 second and thus being stoppedat
deprecation warnings in phpunit