[7.x] Add PHP8 to travis / PHP8 support

prooph / event-store

PHP 7.4 EventStore Implementation

http://getprooph.org

BSD 3-Clause "New" or "Revised" License

547 stars 74 forks source link

[7.x] Add PHP8 to travis / PHP8 support #413

Closed fritz-gerneth closed 3 years ago

fritz-gerneth commented 3 years ago

~~Travis is currently missing the PHP 8 option ( https://travis-ci.community/t/php-8-0-missing/10132/17 ) but should be available next week~~
This is mostly to see if/what needs to change to PHP8 support

Changes:

[x] Updated the README badges to link to the correct branch for this version
[x] Use ProphesizeTrait, prophesize integration has been moved into its own package phpspec/prophecy-phpunit
[x] Replaced calls to assertInternalType() with new assertions ( old ones have been removed )
[x] assertRegExp is deprecated and replaced
[x] Annotated a few tests with @medium that were running longer than 1 second and thus being stopped
[x] Update travis
[x] Fix at deprecation warnings in phpunit
[x] Update Doc-Header for 2021

sandrokeil commented 3 years ago

Maybe we should switch to GitHub actions.

fritz-gerneth commented 3 years ago

With PHP8 not working on Travis there is one apparent problem - other dependencies need to support PHP8 too. For the prooph/* components this probably is realistic. The biggest concern is about phpunit though - the minimum version to use would be phpunit@9 - requiring php > 7.3. That'd bump the version requirements of the prooph packages to 7.3 as well.

sandrokeil commented 3 years ago

I see no problem to increase the minimum PHP version if needed. Maybe rector can be used to make the code automatically compatible if needed. But indeed, some work is needed.

fritz-gerneth commented 3 years ago

Bump the minor version and make it a 7.5 version / branch then?

sandrokeil commented 3 years ago

We already have version 7.5, so it will be 7.6. What do you think @codeliner @prolic ? Should we also increase the PHP minimum version to 7.4? I see no reason to support PHP 7.3 anymore in this new version.

prolic commented 3 years ago

good for me

fritz-gerneth commented 3 years ago

Inherently this is blocked by https://github.com/prooph/php-cs-fixer-config/pull/8 / PHP-CS to support PHP8.

enumag commented 3 years ago

Note that php-cs-fixer (while it's not entirely ready to handle all PHP 8 features) no longer blocks installation under php 8. So in my opinion prooph/php-cs-fixer-config#8 can be merged now.

sandrokeil commented 3 years ago

I've updated https://github.com/prooph/php-cs-fixer-config/pull/8 to support PHP ^7.1 || ^8.0 too.

fritz-gerneth commented 3 years ago

Awesome. I'll update the prooph packages then :)

prolic commented 3 years ago

see https://github.com/prooph/php-cs-fixer-config/releases/tag/v0.4.0

coveralls commented 3 years ago

Coverage decreased (-0.4%) to 99.07% when pulling 3ff1c61bfaa93ad885ae947e14714f43a85ac6a0 on funct:7.x into 9b74792e99e9c5bce2ba8b7580afb3d983f76b02 on prooph:7.x.

fritz-gerneth commented 3 years ago

This should be good for review now :)

prolic commented 3 years ago

Thanks @fritz-gerneth, see here: https://github.com/prooph/event-store/releases/tag/v7.6.0