prooph / event-store

PHP 7.4 EventStore Implementation
http://getprooph.org
BSD 3-Clause "New" or "Revised" License
548 stars 73 forks source link

PHP 8.1 compatibility #425

Closed gquemener closed 2 years ago

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.002%) to 99.068% when pulling fb23b94b8ee31609fff8db50db3cbd6c29585c98 on gquemener:php-8-1-compatibility into 25510bfeb6d85fd18bacf1b6b5f92a11505dbbae on prooph:7.x.

zluiten commented 2 years ago

@prolic Can you have a look at this please?

gquemener commented 2 years ago

Seems like you exceeded your plan on Travis Screenshot from 2022-02-25 17-16-15

https://app.travis-ci.com/github/prooph/event-store/requests

Do you want to move to Github Actions?

prolic commented 2 years ago

Sure why not

On Fri, Feb 25, 2022, 13:17 Gildas Quéméner @.***> wrote:

Seems like you exceeded your plan on Travis [image: Screenshot from 2022-02-25 17-16-15] https://user-images.githubusercontent.com/668604/155749508-86537030-4ccd-4f6b-8b95-9bac0dc6510f.png

https://app.travis-ci.com/github/prooph/event-store/requests

Do you want to move to Github Actions?

— Reply to this email directly, view it on GitHub https://github.com/prooph/event-store/pull/425#issuecomment-1050993745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAJPGSX4DHDFWDXINP3TDU46TSBANCNFSM5KUT4Y4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

gquemener commented 2 years ago

Build is passing, and available here: https://github.com/gquemener/event-store/actions/runs/1903613834.

I haven't setup integration with coveralls.io, as I don't have access to secrets. Here's a documentation about it: https://github.com/marketplace/actions/coveralls-github-action

gquemener commented 2 years ago

Any blocker here? Build looks good to me (apart from the coveralls.io integration which could be done on a separate PR).

zluiten commented 2 years ago

Ping @prolic. Could you have another look please? Thanks!