PHP 8.1, amp v3 - Githubissues

prooph / event-store

PHP 7.4 EventStore Implementation

http://getprooph.org

BSD 3-Clause "New" or "Revised" License

548 stars 73 forks source link

PHP 8.1, amp v3 #426

Closed prolic closed 1 year ago

prolic commented 2 years ago

Require PHP 8.1
make use of Fibers
require amp v3

enumag commented 2 years ago

I'm sorry @prolic but this is simply not reviewable. You're mixing copyright changes, update to 8.1 enums and other 8.1 features, constant renames etc. along with the Fibers update. Way too much noise. Each of these changes should be a separate commit.

Also why are you removing psalm?

prolic commented 2 years ago

Psalm requires amp v2. Too bad. Maybe https://github.com/bamarni/composer-bin-plugin can help or just working with psalm from phar file.

For the rest, you are right, but the fastest way to get this huge refactoring done, was to simply do all changes and afterwards adjust the test-suite once.

Sorry if this makes reviewing a lot harder, but my time is also very limited.