search

prooph / http-middleware

PSR compatible middleware to integrate prooph with a middleware dispatcher
http://getprooph.org/
BSD 3-Clause "New" or "Revised" License
11 stars 4 forks source link

Use query middleware with get request #16

Open Orkin opened 6 years ago

Orkin commented 6 years ago

For now it's not possible to use get request with query middleware. It's only working with post request, is it a intended ?

I think it can be useful in case we use only one query to allow get request like it's possible with CommandMiddleware. We just need to set \Prooph\HttpMiddleware\QueryMiddleware::NAME_ATTRIBUTE to the request attribute.

One more thing, with the post request we have "dependencies" with prooph component because client have to send the attribute prooph_query_name inside. If for any reason we need to change for an other command bus clients could not working or with a weird parameter that do not have any sense.

So I suggest to allow query middleware to handle get request with this purpose :

I propose to use this lib to check request method : fig/http-message-util

Whate do you think ? @prolic @codeliner @basz

prolic commented 6 years ago

@Orkin don't worry for dependency on prooph/service-bus. This middleware is intended to bridge prooph's service bus and a support for any other bus component will never happen within this project. If someone is planning to do the same for SimpleBus, they have to create their own middlewares for it.