search

prooph / pdo-event-store

PDO implementation of ProophEventStore http://getprooph.org
BSD 3-Clause "New" or "Revised" License
111 stars 56 forks source link

Add Schema-Creation to createSchema function #210

Closed heiglandreas closed 5 years ago

heiglandreas commented 5 years ago

Currently when a tableName with a dot is presented the name can correctly be split up into schema and table name. But when the schema does not exist the whole proces breaks as the table can not be created in a non-existing space.

This commit adds an SQL-statement to the createSchema-function that – in case a schema was given – will create the schema when it does not yet exist.

codeliner commented 5 years ago

I'm going to check why some jobs are failing on travis. Looks like a problem not related to the PR.

codeliner commented 5 years ago

Unfortunately, we have an upstream problem that breaks our tests.

Two issues need to be resolved first:

@prolic We could also merge this PR, b/c failing tests are not related to changes made here. What do you think?

codeliner commented 5 years ago

I'm merging the PR. Upstream issues are resolved.