search

prooph / pdo-event-store

PDO implementation of ProophEventStore http://getprooph.org
BSD 3-Clause "New" or "Revised" License
111 stars 56 forks source link

Restores custom strategy backward compatibility #222

Closed gquemener closed 4 years ago

gquemener commented 4 years ago

This PR prevents a BC break introduced in https://github.com/prooph/pdo-event-store/pull/217 by reverting the event stores constructor signature.

It also triggers a deprecation error to prepare users to future BC break (in 2.0.0).

codeliner commented 4 years ago

Awesome! Thank you @gquemener

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.09%) to 84.071% when pulling ce4f7c9c79bb4285797524173af222f65c2fcd75 on gquemener:bc-persistence-strategy into 0681a637ce1e2db5f8737b07ebe355b60cc78415 on prooph:master.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.09%) to 84.071% when pulling ce4f7c9c79bb4285797524173af222f65c2fcd75 on gquemener:bc-persistence-strategy into 0681a637ce1e2db5f8737b07ebe355b60cc78415 on prooph:master.

gquemener commented 4 years ago

/cc @fritz-gerneth as you've initially raised the BC break, could we have your opinion about this PR as well, please?

codeliner commented 4 years ago

@ahmed-alaa can you have a look as well?

ahmed-alaa commented 4 years ago

@codeliner I tried it and works as expected 👍