search

prooph / pdo-event-store

PDO implementation of ProophEventStore http://getprooph.org
BSD 3-Clause "New" or "Revised" License
111 stars 56 forks source link

Php8 support #228

Closed fritz-gerneth closed 3 years ago

fritz-gerneth commented 3 years ago
fritz-gerneth commented 3 years ago

Update event-store repository to mark inherited tests as @long

This is a mean one. The tests here extend abstract test classes from the event-store repository: AbstractEventStoreTest in particular. In the base repository these tests are fast running, in here we need longer test execution.

To fix this we'd need to

In first I was a bit hesitant to just bump the version requirement because of these tags (as for functionality we could still use 7.5.x). But tests in here would not run with 7.5.x at all anyway. So I think the next steps would be to add the tags in the event-store repo, release a new version, and depend on this then.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+5.2%) to 89.426% when pulling d33a0052aa52d0c84923da6eca836e93bbf3b3b9 on funct:php8 into 8f8c3621a8dacd5fc9ee8299e42dc552188b0ea4 on prooph:master.

fritz-gerneth commented 3 years ago

Tests should all run once we can depend on https://github.com/prooph/event-store/pull/418

zluiten commented 3 years ago

@fritz-gerneth Perhaps those tests that need to run longer can be overridden in the concrete classes in this library and given the correct annotation. It would make the tests here a bit more robust by not relying on annotations in a different library.

codeliner commented 3 years ago

@fritz-gerneth what do you think about the suggestion by @netiul ? Sounds like a good idea to me or is it not possible?

fritz-gerneth commented 3 years ago

@fritz-gerneth what do you think about the suggestion by @netiul ? Sounds like a good idea to me or is it not possible?

I am not exactly a fan of it but might be the best option. Will try this the next days.

fritz-gerneth commented 3 years ago

Overwriting does work indeed, though I don't like this solution, or rather more the annotations themselves. They make the tests brittle (e.g. they fail on travis, not my dev environment due to external factors). On the long I'd suggest to disable test timers completely instead.

Everything else should be completed, with modern phpunit and xdebug3, test coverage & CS work again too.

codeliner commented 3 years ago

Thank you so much for taking care of this @fritz-gerneth :clap: