search

prooph / psr7-middleware

Consume prooph messages with a PSR7 middleware
http://getprooph.org/
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

use interface #20

Closed basz closed 7 years ago

basz commented 7 years ago

I noticed the Interface for the response strategy is of a concrete type whist interfaces exists. So I set about to change it.

interface ResponseStrategy
{
    public function fromPromise(PromiseInterface $promise): ResponseInterface;
}

But then I noticed that the PromiseInterface only contains a then method. However I think that is not an issue as the react/promise has merged the two interface for an upcoming release https://github.com/reactphp/promise/commit/d91c9303473ede9ba4d7ff3489d499b2438764b7

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.355% when pulling 1e16c83067b274926bb708e7040b640cee371be1 on basz:promise-interface into edcd30d6692ad791e0ee8dbf1334676fbf7c88d7 on prooph:develop.