prooph / psr7-middleware

Consume prooph messages with a PSR7 middleware
http://getprooph.org/
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

Add satooshi/php-coveralls to require dev #3

Closed codeliner closed 8 years ago

codeliner commented 8 years ago

Let's see if it fixes #2

codeliner commented 8 years ago

@sandrokeil Can you take a look? Error #2 still exists. Not sure, how to solve it.

sandrokeil commented 8 years ago

@codeliner This is not the solution. We have to remove the src_dir defintion. Seems it's not necessary anymore.

codeliner commented 8 years ago

ok, but the same config works for our other components. Do we need to add the dependency? It is missing in current composer.json

prolic commented 8 years ago

src_dir is not necessary, right. See travis on php 5.6:

[Symfony\Component\Config\Definition\Exception\InvalidConfigurationException]  

Unrecognized option "src_dir" under "coveralls"

Coveralls has changed this with 1.0 release (only a few days old).

prolic commented 8 years ago

My question, why is coveralls only executed on 5.6?

sandrokeil commented 8 years ago

@prolic We need only one analysis, because there is no difference between the PHP versions. coveralls is loaded in the travis.yml. However, we should pin it to version 1.0 there.

prolic commented 8 years ago

Another thing:

.travis.yml should be like this:

after_success:

we use after_script, which is always executed.

codeliner commented 8 years ago

everything set, let's see if it works

codeliner commented 8 years ago

new error: [Symfony\Component\Config\Definition\Exception\InvalidConfigurationExcept
ion]
coverage_clover XML file is not readable

codeliner commented 8 years ago

I'm going to merge this PR. @sandrokeil can you try to fix it with a new PR then? I need to finish today.

sandrokeil commented 8 years ago

@codeliner I will check it

prolic commented 8 years ago

build/logs/clover.xml is wrong in https://github.com/prooph/psr7-middleware/blob/master/composer.json#L70

codeliner commented 8 years ago

thx

sandrokeil commented 8 years ago

@prolic My fault, i will fix it. Or you will do. ;-)