Closed bweston92 closed 6 years ago
Imho the docs should be changed, what do you think @codeliner ?
@bweston92 You need interop-config if you want to use the factories in your app, like psr-container
. It's only required for tests. I think the docs are correct.
@sandrokeil so you're saying the docs are for development environments?
The factories are optional and not a requirement for this middleware I think.
On Nov 11, 2017 17:55, "Bradley Weston" notifications@github.com wrote:
@sandrokeil https://github.com/sandrokeil so you're saying the docs are for development environments?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/prooph/psr7-middleware/issues/30#issuecomment-343653462, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYEvDtNQV-_RAsMMyEfYygblZNAuNTYks5s1W7-gaJpZM4QaJBw .
@bweston92 no. @prolic Yes, it's like in the other components too.
We need these dependencies only for unit tests, that's why it's defined in required-dev
. If you want to use any of these factories you have to require interop-config. That's what the docs said. Is there any misleading in the docs and how can we solve it?
@sandrokeil now I think about it the docs are right as it is in the context of factories which is obviously scenario the interop-config
required.
Just come across this problem my self, read the docs and read that interop-config is required however it is only a development dependency.
https://github.com/prooph/psr7-middleware/blob/master/docs/book/factories.md#requirements point 2. https://github.com/prooph/psr7-middleware/blob/master/composer.json#L56