propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 394 forks source link

Alter table syntax for migration with SQL Server is incorrect #1343

Open cameronstubber opened 7 years ago

cameronstubber commented 7 years ago

The current syntax created does not work:

ALTER TABLE [table] ADD
(
    [column1] <type> <options>,
    [column2] <type> <options>,
    [column3] <type> <options>
);

The following syntax does work:

ALTER TABLE [table] ADD [column1] <type> <options>;
ALTER TABLE [table] ADD [column2] <type> <options>;
ALTER TABLE [table] ADD [column2] <type> <options>;
cameronstubber commented 7 years ago

@marcj please assign this issue to me.

MDT-FGI commented 7 years ago

Duplicate of https://github.com/propelorm/Propel2/issues/1294

cameronstubber commented 6 years ago

@atompulse is this something you have fixed? Making the ALTER TABLE syntax do one command per change, instead of ( ALLCHANGES );

cameronstubber commented 6 years ago

@marcj since I dont know how to message you, I will comment. I have a question. Should the version number in propel.php not be updated to 2.0.0-alpha8? I am trying to get alpha8 to check what changes @atompulse has made before I go trying to fix something that isnt broken, but even though I put 2.0.0-alpha8 in my composer.json file, when I run propel, it says version 2.0.0-dev or master whatever it is. What am I missing?

atompulse commented 6 years ago

@cameronstubber I have an active project using MSSQL and I believe that most of the issues should be fixed by my commits.

cameronstubber commented 6 years ago

Ok, I dont suppose you would be willing to help a GIT noob pull your version of changes so I can have a look? I cant seem to get anything but the main branch haha.

On Wed, Mar 21, 2018 at 4:58 PM, atompulse notifications@github.com wrote:

@cameronstubber https://github.com/cameronstubber I have an active project using MSSQL and I believe that most of the issues should be fixed by my commits.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/propelorm/Propel2/issues/1343#issuecomment-374870279, or mute the thread https://github.com/notifications/unsubscribe-auth/ARlMbEairz0NhF9N6AqNqaBEWyv851e_ks5tghZQgaJpZM4L6Tjc .

atompulse commented 6 years ago

@cameronstubber you are not able to fork my version at https://github.com/atompulse/PropelBundle ? I use it in my projects with these composer seetings:

"repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/atompulse/PropelBundle",
      "no-api": true
    },
    {
      "type": "vcs",
      "url": "https://github.com/atompulse/Propel2",
      "no-api": true
    }
  ]
...
"require": {
...
"propel/propel-bundle": "3.0.x-dev"
...
}