Not sure why, but phpstan fails during #1719 and #1720:
Error: ] Found 5 errors
Error: Ignored error pattern #^Call to an undefined static method Propel\\Runtime\\ActiveQuery\\BaseModelCriteria\:\:getShortName\(\)\.$# in path /home/runner/work/Propel2/Propel2/src/Propel/Runtime/ActiveQuery/BaseModelCriteria.php was not matched in reported errors.
Error: Call to an undefined static method static(Propel\Runtime\ActiveQuery\BaseModelCriteria)::getShortName().
Error: Ignored error pattern #^Strict comparison using \!\=\= between null and null will always evaluate to false\.$# in path /home/runner/work/Propel2/Propel2/src/Propel/Runtime/ActiveQuery/Criteria.php was not matched in reported errors.
Error: Ignored error pattern #^Variable \$sql might not be defined\.$# in path /home/runner/work/Propel2/Propel2/src/Propel/Runtime/ActiveQuery/Criteria.php was not matched in reported errors.
Error: Ignored error pattern #^Variable \$sql might not be defined\.$# in path /home/runner/work/Propel2/Propel2/src/Propel/Runtime/ActiveQuery/ModelCriteria.php was not matched in reported errors.
Script vendor/bin/phpstan analyze handling the stan event returned with error code 1
Error: Process completed with exit code 1.
Offending classes (BaseModelCriteria, ModelCriteria and Criteria) have nothing to do with the PRs and have not been changed since January.
The phpstan.neon and phpstan-baseline.neon have not been changed since February and December respectively, and I have run the suite successfully after that.
Running composer run-script stan locally gives no errors
This PR fixes the offending errors (one access of a static child method in parent through static and several times access of a variable declared in a try in the catch block). So with the offending lines and the rules to ignore them gone, the errors might be gone, too.
The actual problem is something else though, since smelly code + ignore warning should have worked, too.
Any idea why this suddenly broke?
Not sure why, but phpstan fails during #1719 and #1720:
composer run-script stanlocally gives no errorsThis PR fixes the offending errors (one access of a static child method in parent through
staticand several times access of a variable declared in atryin thecatchblock). So with the offending lines and the rules to ignore them gone, the errors might be gone, too. The actual problem is something else though, since smelly code + ignore warning should have worked, too. Any idea why this suddenly broke?