search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

fixes duplicate keys in normalizedColumnNameMap #1726

Closed hsegnitz closed 3 years ago

hsegnitz commented 3 years ago

The generated code duplicates keys in the normalized column name map array in certain cases where two variants of how to specify a column accidentally create the exact same spelling.

For example the spelling of a single word column name is the same when using camelcase or snake_case. PHP ignorhes this but many tools flag this as a potential error, hence this fix.

Marked draft as I have to figure out the unit tests

hsegnitz commented 3 years ago

I rebased it to the current master. Anything else I need to do? Do we need to resolve the discussions?

mringler commented 3 years ago

Hey @hsegnitz, Everything is great, all that's left to do is wait. The maintainers seem to have limited time to spend on this project, so it usually takes a while until you see progress. This can be discouraging, and as a fellow contributer, I should have warned you about it. Sorry! In my experience, it does not mean they don't appreciate all your work.

I submitted another PR last week, and I think it blew their capacities. Now I am holding back, not to get in the way of a new contributor. I had hoped, that running the tests would have been approved by now, but what can you do, it takes as long as it takes.

Anyway, again, sorry for not mentioning it earlier.

Best, Moritz