search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Tests for #1507: Import MySQL column/table descriptions during database:reverse & added PDODataFetcher::fetchAll() #1730

Closed mringler closed 3 years ago

mringler commented 3 years ago

Added tests for #1507, which adds an import of column and table descriptions during database:reverse on a MySQL database.

Also, while writing the tests, I again missed PDODataFetcher::fetchAll() (the class has a fetch() method, and in general just wraps PDO methods), so I added it in its own commit (didn't want to put it into its own PR, as I need it in the tests).

If merged, #1507 can be closed.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1730 (ce12c55) into master (3c4c6b5) will decrease coverage by 1.05%. The diff coverage is 16.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1730      +/-   ##
============================================
- Coverage     88.31%   87.25%   -1.06%     
- Complexity     7738     7746       +8     
============================================
  Files           263      263              
  Lines         22206    22228      +22     
============================================
- Hits          19612    19396     -216     
- Misses         2594     2832     +238
Flag Coverage Δ Complexity Δ
5-max 87.25% <16.00%> (-1.06%) 7746.00 <7.00> (+8.00) :arrow_down:
7.4 87.25% <16.00%> (-1.06%) 7746.00 <7.00> (+8.00) :arrow_down:
agnostic 73.62% <0.00%> (-0.09%) 7746.00 <7.00> (+8.00) :arrow_down:
mysql ? ?
pgsql 70.49% <16.00%> (-0.06%) 7745.00 <7.00> (+8.00) :arrow_down:
sqlite 68.43% <16.00%> (-0.06%) 7745.00 <7.00> (+8.00) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Propel/Generator/Reverse/MysqlSchemaParser.php 0.00% <0.00%> (-85.72%) 80.00 <5.00> (+6.00) :arrow_down:
src/Propel/Runtime/DataFetcher/PDODataFetcher.php 82.00% <100.00%> (+1.56%) 25.00 <2.00> (+2.00)
src/Propel/Runtime/Adapter/Pdo/MysqlAdapter.php 41.30% <0.00%> (-36.96%) 23.00% <0.00%> (ø%)
.../Propel/Generator/Reverse/AbstractSchemaParser.php 50.00% <0.00%> (-22.50%) 20.00% <0.00%> (ø%)
src/Propel/Generator/Platform/MysqlPlatform.php 91.02% <0.00%> (-4.49%) 123.00% <0.00%> (ø%)
src/Propel/Generator/Command/InitCommand.php 68.45% <0.00%> (-4.17%) 35.00% <0.00%> (ø%)
src/Propel/Runtime/Adapter/Pdo/PdoAdapter.php 90.28% <0.00%> (-1.15%) 81.00% <0.00%> (ø%)
src/Propel/Generator/Model/Database.php 71.33% <0.00%> (-1.00%) 123.00% <0.00%> (ø%)
...rc/Propel/Runtime/Connection/ConnectionWrapper.php 96.31% <0.00%> (-0.62%) 72.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c4c6b5...ce12c55. Read the comment docs.

mringler commented 3 years ago

@dereuromark something's wrong with CI, tests remain in queued state forever. Started yesterday, between updating PRs. I think I saw them sitll running after the new merges, which shouldn't compromise CI anyway. Can you have a look at that? Maybe you can restart them manually or something?

dereuromark commented 3 years ago

Looks like I also do not have enough rights to see what is going on. Someone with actual maintainer access needs to look into settings and CI topic. @propelorm/propel2 @marcj Are you able to check this please?

dereuromark commented 3 years ago

One more reviewer/approval needed

marcj commented 3 years ago

@dereuromark admin is @PhilinTv.

mringler commented 3 years ago

@dereuromark if you want, you can close #1507 now