search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

propagate output interface in init command #1731

Closed mringler closed 3 years ago

mringler commented 3 years ago

Ok, this is really menial. Still annoyed me after seeing it a million times. Ever wondered what is going on with that one console output ('Successfully wrote PHP configuration in file "/tmp/propel_init/generated-conf/config.php"') during tests? The one around 39%:

> phpunit --colors=always
Tests started in temp /tmp.
PHPUnit 9.5.2 by Sebastian Bergmann and contributors.

.....SS......................................................   61 / 3548 (  1%)
.............................................................  122 / 3548 (  3%)
.............................................................  183 / 3548 (  5%)
.............................................................  244 / 3548 (  6%)
.............................................................  305 / 3548 (  8%)
.............................................................  366 / 3548 ( 10%)
.............................................................  427 / 3548 ( 12%)
.......................S.....................................  488 / 3548 ( 13%)
.............................................................  549 / 3548 ( 15%)
..........................II.................................  610 / 3548 ( 17%)
...........................S.................................  671 / 3548 ( 18%)
.............................................................  732 / 3548 ( 20%)
.............................................................  793 / 3548 ( 22%)
.............................................................  854 / 3548 ( 24%)
.............................................................  915 / 3548 ( 25%)
.............................................................  976 / 3548 ( 27%)
............................................................. 1037 / 3548 ( 29%)
............................................................. 1098 / 3548 ( 30%)
............................................................. 1159 / 3548 ( 32%)
...............................SSSSSSSS.....S................ 1220 / 3548 ( 34%)
............................................................. 1281 / 3548 ( 36%)
............................................................. 1342 / 3548 ( 37%)
.........................Successfully wrote PHP configuration in file "/tmp/propel_init/generated-conf/config.php".
.................................... 1403 / 3548 ( 39%)
...........................................S................. 1464 / 3548 ( 41%)
............................................................. 1525 / 3548 ( 42%)
............................................................. 1586 / 3548 ( 44%)
...

Why does that command create output, while the others do not?

It's pretty simple, the Init command just didn't propagate its output to the nested commands, so the default console output was used, instead of the wrapped output.

Again, menial, but gone is gone.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1731 (fc1100b) into master (8383788) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1731      +/-   ##
============================================
+ Coverage     88.27%   88.31%   +0.04%     
- Complexity     7718     7738      +20     
============================================
  Files           262      263       +1     
  Lines         22133    22207      +74     
============================================
+ Hits          19537    19613      +76     
+ Misses         2596     2594       -2
Flag Coverage Δ Complexity Δ
5-max 88.31% <100.00%> (+0.04%) 7738.00 <3.00> (+20.00)
7.4 88.31% <100.00%> (+0.04%) 7738.00 <3.00> (+20.00)
agnostic 73.70% <0.00%> (+0.02%) 7738.00 <3.00> (+20.00)
mysql 70.40% <100.00%> (+0.11%) 7737.00 <3.00> (+20.00)
pgsql 70.54% <100.00%> (+0.10%) 7737.00 <3.00> (+20.00)
sqlite 68.48% <100.00%> (+0.11%) 7737.00 <3.00> (+20.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Propel/Generator/Command/InitCommand.php 72.78% <100.00%> (+0.16%) 35.00 <3.00> (ø)
src/Propel/Runtime/Connection/PdoConnection.php 77.77% <0.00%> (-0.49%) 23.00% <0.00%> (ø%)
.../Runtime/ActiveQuery/Criterion/ExistsCriterion.php 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
...rc/Propel/Generator/Builder/Om/TableMapBuilder.php 95.61% <0.00%> (+0.04%) 159.00% <0.00%> (ø%)
...rc/Propel/Runtime/Connection/ConnectionWrapper.php 96.93% <0.00%> (+0.11%) 72.00% <0.00%> (+2.00%)
src/Propel/Runtime/ActiveQuery/ModelCriteria.php 95.26% <0.00%> (+0.12%) 287.00% <0.00%> (+6.00%)
src/Propel/Generator/Builder/Om/QueryBuilder.php 91.93% <0.00%> (+0.19%) 159.00% <0.00%> (+2.00%)
...c/Propel/Runtime/ActiveQuery/BaseModelCriteria.php 95.31% <0.00%> (+0.31%) 30.00% <0.00%> (+3.00%)
src/Propel/Runtime/Connection/StatementWrapper.php 62.37% <0.00%> (+0.37%) 47.00% <0.00%> (+2.00%)
...untime/ActiveQuery/Criterion/AbstractCriterion.php 89.10% <0.00%> (+1.98%) 43.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8383788...fc1100b. Read the comment docs.

dereuromark commented 3 years ago

Looks like CI is working again