search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Tests: remove unused fixture #1746

Closed mringler closed 3 years ago

mringler commented 3 years ago

While working on #1742, I stumbled over an unused fixture ('bookstore-packaged'), so I removed it. Two tests (which I wrote) used schema.xml files, but they can easily use others.

Also, I ran into TestCaseFixtures, which was pretty bad (look for the $skip variable if you want to see something funny), and I was in the mood for refactoring.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1746 (e822fe3) into master (f63d3fe) will decrease coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1746      +/-   ##
============================================
- Coverage     87.86%   87.83%   -0.04%     
  Complexity     7785     7785              
============================================
  Files           265      265              
  Lines         22393    22393              
============================================
- Hits          19676    19668       -8     
- Misses         2717     2725       +8
Flag Coverage Δ
5-max 87.83% <ø> (-0.04%) :arrow_down:
7.4 87.83% <ø> (-0.04%) :arrow_down:
agnostic 73.34% <ø> (-0.02%) :arrow_down:
mysql 69.77% <ø> (-0.27%) :arrow_down:
pgsql 69.76% <ø> (-0.27%) :arrow_down:
sqlite 67.72% <ø> (-0.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Propel/Generator/Command/TestPrepareCommand.php 95.00% <ø> (ø)
src/Propel/Generator/Manager/AbstractManager.php 77.20% <0.00%> (-4.42%) :arrow_down:
src/Propel/Generator/Manager/SqlManager.php 80.88% <0.00%> (-2.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f63d3fe...e822fe3. Read the comment docs.