search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Refactor Propel\Common #1753

Closed ikeyan closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #1753 (07a55f4) into master (9d5c105) will increase coverage by 0.00%. The diff coverage is 98.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1753   +/-   ##
=========================================
  Coverage     87.87%   87.88%           
+ Complexity     7823     7806   -17     
=========================================
  Files           267      267           
  Lines         22522    22518    -4     
=========================================
- Hits          19792    19789    -3     
+ Misses         2730     2729    -1
Flag Coverage Δ
5-max 87.88% <98.28%> (+<0.01%) :arrow_up:
7.4 87.88% <98.28%> (+<0.01%) :arrow_up:
agnostic 73.31% <98.28%> (-0.06%) :arrow_down:
mysql 69.91% <47.42%> (+0.06%) :arrow_up:
pgsql 69.84% <47.42%> (+0.06%) :arrow_up:
sqlite 67.83% <47.42%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Common/Config/Loader/IniFileLoader.php 94.23% <91.66%> (ø)
src/Propel/Common/Config/ConfigurationManager.php 98.98% <100.00%> (-0.04%) :arrow_down:
...opel/Common/Config/Exception/XmlParseException.php 81.81% <100.00%> (ø)
src/Propel/Common/Config/Loader/FileLoader.php 97.84% <100.00%> (-0.32%) :arrow_down:
src/Propel/Common/Config/Loader/JsonFileLoader.php 100.00% <100.00%> (ø)
src/Propel/Common/Config/Loader/PhpFileLoader.php 100.00% <100.00%> (ø)
src/Propel/Common/Config/Loader/XmlFileLoader.php 100.00% <100.00%> (ø)
src/Propel/Common/Config/Loader/YamlFileLoader.php 100.00% <100.00%> (ø)
src/Propel/Common/Config/PropelConfiguration.php 99.67% <100.00%> (+0.31%) :arrow_up:
src/Propel/Common/Config/XmlToArrayConverter.php 93.10% <100.00%> (-0.23%) :arrow_down:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d5c105...07a55f4. Read the comment docs.

ikeyan commented 3 years ago

CI says "This check failed," but I don't see the reason...

dereuromark commented 3 years ago

I triggered a rerun.

ikeyan commented 3 years ago

@dereuromark ping

dereuromark commented 3 years ago

Hi! We have had extensive testing and BC checking on the current master and are about to tag a beta release. I am not sure if we should merge this in now. I think better to finish the tagging and then merge this into master for next beta release. If that's ok with you

As for the tag, we are currently waiting for feedback on a reversal of a BC issue regarding order of query settings. See the "beta" issue. If we resolve this this week we can merge this as soon as FR evening.

dereuromark commented 3 years ago

Any additional reviews here so we can merge this?