refactor getExecutedQueryString

[codecov-commenter]

Codecov Report

Merging #1754 (5c3df8f) into master (5048947) will decrease coverage by 0.00%. The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #1754      +/-   ##
============================================
- Coverage     87.88%   87.87%   -0.01%     
+ Complexity     7807     7802       -5     
============================================
  Files           267      267              
  Lines         22484    22479       -5     
============================================
- Hits          19759    19754       -5     
  Misses         2725     2725              

Flag	Coverage Δ
5-max	87.87% <85.71%> (-0.01%)	:arrow_down:
7.4	87.87% <85.71%> (-0.01%)	:arrow_down:
agnostic	73.43% <85.71%> (-0.01%)	:arrow_down:
mysql	69.84% <85.71%> (-0.01%)	:arrow_down:
pgsql	69.83% <85.71%> (-0.01%)	:arrow_down:
sqlite	67.81% <85.71%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Propel/Runtime/Connection/StatementWrapper.php	62.50% <85.71%> (-1.86%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5048947...5c3df8f. Read the comment docs.

[mringler]

Really nice! Not sure why the one test fails, but I have experienced the same error. Just pushing the commit again works for me:

git commit --amend --no-edit
git push -f

[dereuromark]

OK, so we agree that we want to fix up the signatures for the upcoming beta release to contain

• param types
• return types

wherever this is feasible and reasonable - that means it should not break any code. If current (extended) code could be in the "wrong type" we should rather skip then to avoid too many bc breaking issues.