search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

add howto url to missing loader script exception #1757

Closed mringler closed 3 years ago

mringler commented 3 years ago

In order to reduce confusion and resulting bug reports about an outdated configuration or missing database import, I have created a howto page in the Propel2 wiki at https://github.com/propelorm/Propel2/wiki/Exception-Target:-Loading-the-database, and I have added the URL to the exception message.

I am not sure if the wiki is the correct location, but I am not sure if the official documentation is still maintained, so the wiki seems like the next best thing. Please let me know if the howto should go somewhere else. I'd prefer a perma link

codecov-commenter commented 3 years ago

Codecov Report

Merging #1757 (b80a37b) into master (5048947) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1757      +/-   ##
============================================
- Coverage     87.88%   87.88%   -0.01%     
- Complexity     7807     7827      +20     
============================================
  Files           267      267              
  Lines         22484    22525      +41     
============================================
+ Hits          19759    19795      +36     
- Misses         2725     2730       +5
Flag Coverage Δ
5-max 87.88% <100.00%> (-0.01%) :arrow_down:
7.4 87.88% <100.00%> (-0.01%) :arrow_down:
agnostic 73.37% <100.00%> (-0.07%) :arrow_down:
mysql 69.85% <0.00%> (+<0.01%) :arrow_up:
pgsql 69.79% <0.00%> (-0.06%) :arrow_down:
sqlite 67.77% <0.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...time/ServiceContainer/StandardServiceContainer.php 85.51% <100.00%> (+0.51%) :arrow_up:
src/Propel/Generator/Platform/MysqlPlatform.php 94.29% <0.00%> (-1.22%) :arrow_down:
src/Propel/Generator/Model/Diff/TableDiff.php 100.00% <0.00%> (ø)
src/Propel/Generator/Reverse/MysqlSchemaParser.php 86.60% <0.00%> (ø)
...nerator/Builder/Om/templates/baseObjectMethods.php 100.00% <0.00%> (ø)
...ehavior/I18n/templates/objectRemoveTranslation.php 100.00% <0.00%> (ø)
src/Propel/Generator/Platform/DefaultPlatform.php 94.14% <0.00%> (+0.04%) :arrow_up:
.../Propel/Generator/Command/MigrationDiffCommand.php 81.60% <0.00%> (+0.14%) :arrow_up:
src/Propel/Generator/Model/ForeignKey.php 94.61% <0.00%> (+0.18%) :arrow_up:
...opel/Generator/Model/Diff/ForeignKeyComparator.php 93.75% <0.00%> (+0.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5048947...b80a37b. Read the comment docs.

mringler commented 3 years ago

@gechetspr Thank you for the review. I updated the code as you requested. @dereuromark Thanks for finding the typo

First CI run after push failed, when the connection to the database could not be established (see here). Currently, this happens every other time I push a commit.