Closed nederdirk closed 3 years ago
Merging #1766 (1c30980) into master (9d5c105) will decrease coverage by
0.00%
. The diff coverage is92.85%
.
@@ Coverage Diff @@
## master #1766 +/- ##
============================================
- Coverage 87.87% 87.87% -0.01%
- Complexity 7823 7825 +2
============================================
Files 267 267
Lines 22522 22543 +21
============================================
+ Hits 19792 19809 +17
- Misses 2730 2734 +4
Flag | Coverage Δ | |
---|---|---|
5-max | 87.87% <92.85%> (-0.01%) |
:arrow_down: |
7.4 | 87.87% <92.85%> (-0.01%) |
:arrow_down: |
agnostic | 73.34% <85.71%> (-0.04%) |
:arrow_down: |
mysql | 69.86% <92.85%> (+0.02%) |
:arrow_up: |
pgsql | 69.80% <92.85%> (+0.02%) |
:arrow_up: |
sqlite | 67.78% <92.85%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/Propel/Generator/Builder/Om/ObjectBuilder.php | 94.37% <88.88%> (-0.02%) |
:arrow_down: |
src/Propel/Generator/Builder/Om/QueryBuilder.php | 91.93% <100.00%> (+0.03%) |
:arrow_up: |
src/Propel/Runtime/Formatter/OnDemandFormatter.php | 82.14% <0.00%> (-2.18%) |
:arrow_down: |
src/Propel/Runtime/Formatter/ArrayFormatter.php | 84.94% <0.00%> (-0.93%) |
:arrow_down: |
...rc/Propel/Runtime/Connection/ConnectionWrapper.php | 96.29% <0.00%> (-0.64%) |
:arrow_down: |
src/Propel/Runtime/Map/TableMap.php | 93.01% <0.00%> (-0.12%) |
:arrow_down: |
src/Propel/Runtime/ActiveQuery/ModelCriteria.php | 94.82% <0.00%> (-0.11%) |
:arrow_down: |
src/Propel/Runtime/Collection/Collection.php | 95.27% <0.00%> (ø) |
|
src/Propel/Runtime/Formatter/AbstractFormatter.php | 76.19% <0.00%> (ø) |
|
...c/Propel/Runtime/ActiveQuery/BaseModelCriteria.php | 95.58% <0.00%> (ø) |
|
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9d5c105...1c30980. Read the comment docs.
[approved] Apart from small alignment issues
Fixed!
In the query baseclass generator, some
@psalm-method
lines were used, because PHPstan doesn't support prefixed@method
-annotations currently (2021-07-12). The two tools have a good history of supporting each other's prefixes, so chances are that PHPstan will pick up the@psalm-
prefixed annotations in the future.