Sometimes we use boxed primitives for types that have more specific semantics than just string or int. This allows us to define methods on the boxed primitives, enabling greater class coherence.
However, entities with boxed primitives are always reported as 'does not have only default values', because the hasOnlyDefaultValues function uses !==. Generally this is a good idea, but for objects this compares the references instead of the contents.
This patch inspects the default-value initialiser for 'starts with new', as a proxy for 'is this an object type'.
There's a test to validate this behaviour. I validated that the test fails with the unpatched ObjectBuilder code.
Sometimes we use boxed primitives for types that have more specific semantics than just
stringorint. This allows us to define methods on the boxed primitives, enabling greater class coherence.However, entities with boxed primitives are always reported as 'does not have only default values', because the
hasOnlyDefaultValuesfunction uses!==. Generally this is a good idea, but for objects this compares the references instead of the contents.This patch inspects the default-value initialiser for 'starts with
new', as a proxy for 'is this an object type'.There's a test to validate this behaviour. I validated that the test fails with the unpatched
ObjectBuildercode.