search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Reintroduce late select for backward compatibility #1782

Closed mringler closed 3 years ago

mringler commented 3 years ago

Undoes most of the changes from https://github.com/propelorm/Propel2/pull/1711 as requested in https://github.com/propelorm/Propel2/issues/1733#issuecomment-907154887

codecov-commenter commented 3 years ago

Codecov Report

Merging #1782 (3caa4bf) into master (faf29e2) will increase coverage by 0.00%. The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1782   +/-   ##
=========================================
  Coverage     87.93%   87.93%           
- Complexity     7870     7873    +3     
=========================================
  Files           281      281           
  Lines         22670    22685   +15     
=========================================
+ Hits          19934    19948   +14     
- Misses         2736     2737    +1
Flag Coverage Δ
5-max 87.93% <96.42%> (+<0.01%) :arrow_up:
7.4 87.93% <96.42%> (+<0.01%) :arrow_up:
agnostic 67.40% <35.71%> (-0.05%) :arrow_down:
mysql 70.40% <96.42%> (+0.02%) :arrow_up:
pgsql 70.35% <96.42%> (+0.02%) :arrow_up:
sqlite 68.33% <96.42%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nerator/Behavior/QueryCache/QueryCacheBehavior.php 75.00% <ø> (ø)
src/Propel/Generator/Builder/Om/QueryBuilder.php 91.93% <ø> (ø)
src/Propel/Runtime/ActiveQuery/ModelCriteria.php 95.67% <96.42%> (+0.35%) :arrow_up:
.../Propel/Runtime/Formatter/SimpleArrayFormatter.php 74.41% <0.00%> (-5.59%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faf29e2...3caa4bf. Read the comment docs.

dereuromark commented 3 years ago

Do we still keep some of the fixes and Improvements of the original PR here?

Thank you for the efforts, I think we can release then now and can rediscuss further Improvements for next beta without hurries.

mringler commented 3 years ago

The old PR also introduced setting the base table at create time, instead of having to initialize it during query building. That part is still there. Probably should have put it into its own PR anyway.

dereuromark commented 3 years ago

I merged it as we will do another QA session tomorrow and finish our release then based on the result.