search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Fix Psalm issues #1790

Closed cristianoc72 closed 3 years ago

cristianoc72 commented 3 years ago

Minor fixes, suggested by Psalm. Basically, I changed some variables name and refactored a very small piece of code, to safely retrieve the Sqlite version number.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1790 (596ff79) into master (31b45e9) will decrease coverage by 0.00%. The diff coverage is 84.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1790      +/-   ##
============================================
- Coverage     87.92%   87.91%   -0.01%     
- Complexity     7855     7858       +3     
============================================
  Files           281      281              
  Lines         22668    22673       +5     
============================================
+ Hits          19931    19934       +3     
- Misses         2737     2739       +2
Flag Coverage Δ
5-max 87.91% <84.37%> (-0.01%) :arrow_down:
7.4 87.91% <84.37%> (-0.01%) :arrow_down:
agnostic 67.37% <62.50%> (-0.01%) :arrow_down:
mysql 70.43% <75.00%> (-0.01%) :arrow_down:
pgsql 70.38% <62.50%> (-0.01%) :arrow_down:
sqlite 68.35% <53.12%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...el/Runtime/Connection/ProfilerStatementWrapper.php 0.00% <0.00%> (ø)
src/Propel/Generator/Platform/SqlitePlatform.php 92.99% <66.66%> (-0.82%) :arrow_down:
src/Propel/Generator/Platform/DefaultPlatform.php 94.16% <88.88%> (ø)
src/Propel/Generator/Model/Table.php 90.92% <100.00%> (ø)
src/Propel/Generator/Platform/PgsqlPlatform.php 97.50% <100.00%> (ø)
src/Propel/Generator/Reverse/MysqlSchemaParser.php 86.60% <100.00%> (ø)
src/Propel/Runtime/Adapter/Pdo/MysqlAdapter.php 78.26% <100.00%> (ø)
src/Propel/Runtime/Connection/StatementWrapper.php 62.88% <100.00%> (+0.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31b45e9...596ff79. Read the comment docs.