propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

use bail early principle and noncloaking #1800

Closed javray closed 2 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #1800 (9faa34c) into master (e8527af) will increase coverage by 0.29%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1800      +/-   ##
============================================
+ Coverage     87.51%   87.80%   +0.29%     
- Complexity     7858     7859       +1     
============================================
  Files           281      281              
  Lines         22778    22706      -72     
============================================
+ Hits          19935    19938       +3     
+ Misses         2843     2768      -75     
Flag Coverage Δ
5-max 87.80% <100.00%> (+0.29%) :arrow_up:
7.4 87.80% <100.00%> (+0.29%) :arrow_up:
agnostic 68.49% <100.00%> (+1.41%) :arrow_up:
mysql 70.50% <100.00%> (+0.12%) :arrow_up:
pgsql 70.38% <100.00%> (+0.02%) :arrow_up:
sqlite 68.43% <100.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Propel/Runtime/ActiveQuery/InstancePoolTrait.php 100.00% <100.00%> (ø)
...onable/VersionableBehaviorQueryBuilderModifier.php 0.00% <0.00%> (ø)
...nable/VersionableBehaviorObjectBuilderModifier.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8527af...9faa34c. Read the comment docs.