search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Update to PHP7.3+ and PHPStan 1.0+ #1803

Closed dereuromark closed 2 years ago

dereuromark commented 2 years ago

Also

TODO in follow up: Adding Symf v6 compatibility

Note: ControlStructures.AssignmentInCondition.AssignmentInCondition is silenced for now as this creates too much manual work This can and should be a follow up PR.

The failing remaining CS issue is fixed in code sniffer and will be green once we merge.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1803 (59d7a73) into master (d1813f7) will increase coverage by 0.04%. The diff coverage is 85.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1803      +/-   ##
============================================
+ Coverage     87.80%   87.85%   +0.04%     
+ Complexity     7859     7816      -43     
============================================
  Files           281      281              
  Lines         22706    22710       +4     
============================================
+ Hits          19938    19951      +13     
+ Misses         2768     2759       -9
Flag Coverage Δ
5-max 87.85% <85.38%> (+0.04%) :arrow_up:
7.4 87.85% <85.38%> (+0.04%) :arrow_up:
agnostic 68.54% <73.30%> (+0.04%) :arrow_up:
mysql 70.55% <67.91%> (+0.04%) :arrow_up:
pgsql 70.43% <67.76%> (+0.04%) :arrow_up:
sqlite 68.47% <63.82%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Common/Config/ConfigurationManager.php 98.98% <ø> (ø)
src/Propel/Common/Config/FileLocator.php 100.00% <ø> (ø)
src/Propel/Common/Config/Loader/FileLoader.php 97.84% <ø> (ø)
src/Propel/Common/Config/Loader/IniFileLoader.php 94.23% <ø> (ø)
...el/Common/Pluralizer/StandardEnglishPluralizer.php 100.00% <ø> (ø)
src/Propel/Common/Util/SetColumnConverter.php 100.00% <ø> (ø)
src/Propel/Generator/Application.php 0.00% <ø> (ø)
...Generator/Behavior/AutoAddPk/AutoAddPkBehavior.php 50.00% <ø> (ø)
...oncreteInheritance/ConcreteInheritanceBehavior.php 96.73% <ø> (ø)
...eInheritance/ConcreteInheritanceParentBehavior.php 100.00% <ø> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1813f7...59d7a73. Read the comment docs.

dereuromark commented 2 years ago

anyone else being able to review? cc @nederdirk @mringler