Closed fbourigault closed 2 years ago
Merging #1815 (d602d8e) into master (d9817c1) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #1815 +/- ##
=========================================
Coverage 87.83% 87.83%
Complexity 7836 7836
=========================================
Files 281 281
Lines 22748 22748
=========================================
Hits 19981 19981
Misses 2767 2767
Flag | Coverage Δ | |
---|---|---|
5-max | 87.83% <100.00%> (ø) |
|
7.4 | 87.83% <100.00%> (ø) |
|
agnostic | 68.54% <0.00%> (ø) |
|
mysql | 70.53% <100.00%> (ø) |
|
pgsql | 70.42% <100.00%> (ø) |
|
sqlite | 68.46% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...pel/Generator/Command/Console/Input/ArrayInput.php | 44.28% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d9817c1...d602d8e. Read the comment docs.
Now psalm job is fixed, I get 11 errors related to added return types in Symfony 6.
I checked those errors and are all enforcing the 5.x behavior.
Should I add those errors to the baseline to keep the current behavior?
I guess so. They are not functionally relevant, are they?
In a next step we need to get rid of at least v3 here. That might also simplify a few things.
Lets focus on getting this merged first, so we can easier then finalize also the v3 removal PR.
I did some cleanup in tests/composer
:
composer-php8.json
as it seems unused.
This allows Symfony 6 components.
This is a draft ATM because I only ran some tests locally.
CI failure seems unrelated. See https://github.com/composer/composer/issues/10387.