search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 398 forks source link

Use explode() instead of preg_split(). #1823

Closed dereuromark closed 2 years ago

dereuromark commented 2 years ago

as per IDE recommendation.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1823 (c93782a) into master (39203e1) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1823   +/-   ##
=========================================
  Coverage     88.11%   88.12%           
  Complexity     7773     7773           
=========================================
  Files           279      279           
  Lines         22634    22636    +2     
=========================================
+ Hits          19945    19947    +2     
  Misses         2689     2689
Flag Coverage Δ
5-max 88.12% <100.00%> (+<0.01%) :arrow_up:
7.4 88.12% <100.00%> (+<0.01%) :arrow_up:
agnostic 68.88% <55.55%> (-0.01%) :arrow_down:
mysql 70.72% <55.55%> (+<0.01%) :arrow_up:
pgsql 70.60% <11.11%> (-0.01%) :arrow_down:
sqlite 68.63% <11.11%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Generator/Command/AbstractCommand.php 89.83% <100.00%> (ø)
src/Propel/Generator/Reverse/MysqlSchemaParser.php 86.72% <100.00%> (+0.11%) :arrow_up:
src/Propel/Runtime/Parser/CsvParser.php 88.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39203e1...c93782a. Read the comment docs.