search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Prevent errors with Monolog 2.3 and no default log config #1825

Closed manstie closed 2 years ago

manstie commented 2 years ago

Passing in null to the handler classes (which now have typed parameters in the constructors) causes an error. Changed null coalescing to default values instead of null.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1825 (9adb59f) into master (5ebc194) will not change coverage. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1825   +/-   ##
=========================================
  Coverage     88.12%   88.12%           
  Complexity     7773     7773           
=========================================
  Files           279      279           
  Lines         22636    22636           
=========================================
  Hits          19947    19947           
  Misses         2689     2689
Flag Coverage Δ
5-max 88.12% <25.00%> (ø)
7.4 88.12% <25.00%> (ø)
agnostic 68.88% <25.00%> (ø)
mysql 70.72% <0.00%> (ø)
pgsql 70.60% <0.00%> (ø)
sqlite 68.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...time/ServiceContainer/StandardServiceContainer.php 85.51% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ebc194...9adb59f. Read the comment docs.