Closed dereuromark closed 2 years ago
Merging #1855 (86da93a) into master (d4c4392) will decrease coverage by
0.03%
. The diff coverage is25.00%
.
@@ Coverage Diff @@
## master #1855 +/- ##
============================================
- Coverage 87.84% 87.81% -0.04%
- Complexity 7766 7769 +3
============================================
Files 226 226
Lines 21043 21053 +10
============================================
+ Hits 18486 18488 +2
- Misses 2557 2565 +8
Flag | Coverage Δ | |
---|---|---|
5-max | 87.81% <25.00%> (-0.04%) |
:arrow_down: |
7.4 | 87.81% <25.00%> (-0.04%) |
:arrow_down: |
agnostic | 67.09% <25.00%> (-0.03%) |
:arrow_down: |
mysql | 69.08% <25.00%> (-0.03%) |
:arrow_down: |
pgsql | 69.10% <25.00%> (-0.03%) |
:arrow_down: |
sqlite | 66.92% <25.00%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/Propel/Common/Util/PathTrait.php | 67.85% <25.00%> (-26.59%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d4c4392...86da93a. Read the comment docs.
Could someone dev-qa and approve this please? @mringler @oojacoboo etc
Logic seems okay, but I don't fully know what input and output to expect here, so it's hard to give it much scrutiny.
You can see the linked pr for previous template paths
Follow https://github.com/propelorm/Propel2/pull/1848
Just to make sure we ease the upgrade issues here for folks that use behaviors or other custom repositories with extension and templates.