search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 396 forks source link

[WIP] Added template for phpstan #1859

Open dmytro-dymarchuk opened 2 years ago

dmytro-dymarchuk commented 2 years ago

Inspired by https://github.com/propelorm/Propel2/pull/1657

codecov-commenter commented 2 years ago

Codecov Report

Merging #1859 (9bd9611) into master (0cfea4e) will increase coverage by 0.00%. The diff coverage is 71.42%.

@@            Coverage Diff            @@
##             master    #1859   +/-   ##
=========================================
  Coverage     87.58%   87.58%           
+ Complexity     7791     7790    -1     
=========================================
  Files           227      227           
  Lines         21105    21109    +4     
=========================================
+ Hits          18485    18489    +4     
  Misses         2620     2620
Flag Coverage Δ
5-max 87.58% <71.42%> (+<0.01%) :arrow_up:
7.4 87.58% <71.42%> (+<0.01%) :arrow_up:
agnostic 66.91% <42.85%> (+0.01%) :arrow_up:
mysql 68.84% <42.85%> (-0.02%) :arrow_down:
pgsql 68.85% <42.85%> (-0.02%) :arrow_down:
sqlite 66.68% <42.85%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Generator/Builder/Om/ObjectBuilder.php 94.16% <ø> (ø)
...c/Propel/Runtime/ActiveQuery/BaseModelCriteria.php 83.33% <ø> (ø)
src/Propel/Runtime/ActiveQuery/ModelCriteria.php 96.66% <ø> (ø)
src/Propel/Runtime/Collection/ArrayCollection.php 90.00% <ø> (ø)
...c/Propel/Runtime/Collection/CollectionIterator.php 52.50% <ø> (ø)
src/Propel/Runtime/Collection/ObjectCollection.php 96.95% <ø> (ø)
...Runtime/Collection/ObjectCombinationCollection.php 72.72% <ø> (ø)
...c/Propel/Runtime/Collection/OnDemandCollection.php 63.15% <ø> (ø)
src/Propel/Runtime/Collection/OnDemandIterator.php 93.54% <ø> (ø)
src/Propel/Runtime/Formatter/AbstractFormatter.php 76.19% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cfea4e...9bd9611. Read the comment docs.

dereuromark commented 2 years ago

30 errors found psalm aint too happy yet

dereuromark commented 1 year ago

Can we extract some of the cleanups from this already maybe?

dereuromark commented 1 year ago

@dmytro-dymarchuk Any update on this?