search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 396 forks source link

Adjusted sortable behavior to be consistent. #1861

Closed dereuromark closed 2 years ago

dereuromark commented 2 years ago

Refs https://github.com/propelorm/Propel2/issues/1842

Is there any way moveToBottom() needs to be different than moveToTop()?

codecov-commenter commented 2 years ago

Codecov Report

Merging #1861 (9c3a50e) into master (428eccd) will decrease coverage by 20.66%. The diff coverage is 67.34%.

@@              Coverage Diff              @@
##             master    #1861       +/-   ##
=============================================
- Coverage     87.58%   66.91%   -20.67%     
  Complexity     7791     7791               
=============================================
  Files           227      227               
  Lines         21114    21020       -94     
=============================================
- Hits          18492    14066     -4426     
- Misses         2622     6954     +4332
Flag Coverage Δ
5-max 66.91% <67.34%> (-20.67%) :arrow_down:
7.4 66.91% <67.34%> (-20.67%) :arrow_down:
agnostic 66.91% <67.34%> (+0.01%) :arrow_up:
mysql ?
pgsql ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oncreteInheritance/ConcreteInheritanceBehavior.php 90.84% <ø> (-5.64%) :arrow_down:
...eInheritance/ConcreteInheritanceParentBehavior.php 100.00% <ø> (ø)
...l/Generator/Behavior/Delegate/DelegateBehavior.php 93.02% <ø> (+2.79%) :arrow_up:
...stedSet/NestedSetBehaviorObjectBuilderModifier.php 100.00% <ø> (+3.34%) :arrow_up:
...l/Generator/Behavior/Sortable/SortableBehavior.php 31.94% <0.00%> (-65.28%) :arrow_down:
...Sortable/SortableBehaviorObjectBuilderModifier.php 0.00% <0.00%> (-95.42%) :arrow_down:
.../Sortable/SortableBehaviorQueryBuilderModifier.php 0.00% <0.00%> (-92.27%) :arrow_down:
...nable/VersionableBehaviorObjectBuilderModifier.php 0.00% <0.00%> (ø)
...onable/VersionableBehaviorQueryBuilderModifier.php 0.00% <ø> (ø)
src/Propel/Generator/Builder/Om/QueryBuilder.php 87.83% <ø> (-2.20%) :arrow_down:
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d47726...9c3a50e. Read the comment docs.