search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 396 forks source link

Cleanup of ModelCriteria class #1864

Closed yaroslav-spryker closed 2 years ago

dereuromark commented 2 years ago

Are you able to finish this up today? We need to start closing changes and start QA phase for release.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1864 (044e4e1) into master (2896118) will increase coverage by 0.00%. The diff coverage is 89.70%.

@@            Coverage Diff            @@
##             master    #1864   +/-   ##
=========================================
  Coverage     87.61%   87.61%           
- Complexity     7794     7807   +13     
=========================================
  Files           227      227           
  Lines         21120    21144   +24     
=========================================
+ Hits          18504    18526   +22     
- Misses         2616     2618    +2
Flag Coverage Δ
5-max 87.61% <89.70%> (+<0.01%) :arrow_up:
7.4 87.61% <89.70%> (+<0.01%) :arrow_up:
agnostic 66.96% <67.64%> (+<0.01%) :arrow_up:
mysql 68.91% <86.76%> (+0.02%) :arrow_up:
pgsql 68.93% <86.76%> (+0.02%) :arrow_up:
sqlite 66.75% <86.76%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Runtime/ActiveQuery/ModelJoin.php 67.60% <80.00%> (+0.93%) :arrow_up:
src/Propel/Generator/Builder/DataModelBuilder.php 89.09% <83.33%> (-0.44%) :arrow_down:
src/Propel/Runtime/ActiveQuery/ModelCriteria.php 96.30% <88.88%> (-0.37%) :arrow_down:
src/Propel/Generator/Builder/Om/ObjectBuilder.php 94.11% <91.66%> (-0.06%) :arrow_down:
src/Propel/Common/Config/FileLocator.php 100.00% <100.00%> (ø)
src/Propel/Common/Config/Loader/FileLoader.php 97.87% <100.00%> (+0.04%) :arrow_up:
src/Propel/Common/Config/Loader/JsonFileLoader.php 100.00% <100.00%> (ø)
src/Propel/Common/Config/Loader/YamlFileLoader.php 100.00% <100.00%> (ø)
...rc/Propel/Generator/Builder/Om/TableMapBuilder.php 95.27% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2896118...044e4e1. Read the comment docs.