search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

restore service container after tests #1879

Closed mringler closed 2 years ago

mringler commented 2 years ago

Umph, a test I added recently had some unintended consequences, breaking subsequent tests. Not sure why it didn't show sooner.

In the test, the ServiceContainer was changed, but not reset, leading to missing configuration data downstream (mocked adapter, mocked table maps, etc.) and around 40 failing tests with weird error messages.

Pretty stoopid...

codecov-commenter commented 2 years ago

Codecov Report

Merging #1879 (68a99f5) into master (0fd64ee) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1879   +/-   ##
=========================================
  Coverage     87.61%   87.61%           
  Complexity     7814     7814           
=========================================
  Files           227      227           
  Lines         21160    21160           
=========================================
  Hits          18540    18540           
  Misses         2620     2620
Flag Coverage Δ
5-max 87.61% <ø> (ø)
7.4 87.61% <ø> (ø)
agnostic 66.99% <ø> (ø)
mysql 68.88% <ø> (ø)
pgsql 68.90% <ø> (ø)
sqlite 66.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fd64ee...68a99f5. Read the comment docs.