search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

MSSQL/SQLSrv Datetime format fixes #1881

Closed DarkAxi0m closed 2 years ago

DarkAxi0m commented 2 years ago

I know there is an older PR https://github.com/propelorm/Propel2/pull/1328 that covers this change, But it's based on 2017 code, and does not look like its going to cleaned up anytime soon.

I have just taken the DateTime fix to it's own PR.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1881 (97c71de) into master (2f479f5) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1881   +/-   ##
=========================================
  Coverage     87.61%   87.61%           
  Complexity     7814     7814           
=========================================
  Files           227      227           
  Lines         21160    21160           
=========================================
  Hits          18540    18540           
  Misses         2620     2620
Flag Coverage Δ
5-max 87.61% <ø> (ø)
7.4 87.61% <ø> (ø)
agnostic 66.99% <ø> (ø)
mysql 68.88% <ø> (ø)
pgsql 68.90% <ø> (ø)
sqlite 66.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f479f5...97c71de. Read the comment docs.

dereuromark commented 2 years ago

Ideally this would come with a test case, but I am fine with it either way if it improves the situation.

DarkAxi0m commented 2 years ago

Ideally this would come with a test case, but I am fine with it either way if it improves the situation.

I just had a quick look now, am I right in assuming there are no tests on MSSQL DBs currently?