search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 396 forks source link

Added a common return type for Collection::getIterator() method #1889

Closed gechetspr closed 2 years ago

gechetspr commented 2 years ago

OnDemandCollection::getIterator docblock has not compatible type with the base class. Added a common type for both classes

codecov-commenter commented 2 years ago

Codecov Report

Merging #1889 (805531c) into master (0f39bb2) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1889   +/-   ##
=========================================
  Coverage     87.61%   87.61%           
  Complexity     7814     7814           
=========================================
  Files           227      227           
  Lines         21161    21161           
=========================================
  Hits          18541    18541           
  Misses         2620     2620
Flag Coverage Δ
5-max 87.61% <ø> (ø)
7.4 87.61% <ø> (ø)
agnostic 66.99% <ø> (ø)
mysql 68.88% <ø> (ø)
pgsql 68.89% <ø> (ø)
sqlite 66.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Runtime/Collection/Collection.php 94.80% <ø> (ø)
...c/Propel/Runtime/Collection/CollectionIterator.php 52.50% <ø> (ø)
...c/Propel/Runtime/Collection/OnDemandCollection.php 63.15% <ø> (ø)
src/Propel/Runtime/Collection/OnDemandIterator.php 93.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f39bb2...805531c. Read the comment docs.