propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 396 forks source link

Fix invalid duplicate indices using ArchivableBehavior for some platforms #1904

Closed felixgeyer closed 2 years ago

felixgeyer commented 2 years ago

Resolves #1894

Please let me know, if we can write tests for this behavior depending on different platforms. Without the fix, test setup will fail because of the error described in the linked issue.

To keep it more simple, we could also discuss to never copy the original's index name which might be a breaking change if someone relies on the archive index name.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1904 (af565f1) into master (966046e) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1904   +/-   ##
=========================================
  Coverage     87.64%   87.64%           
- Complexity     7825     7828    +3     
=========================================
  Files           227      227           
  Lines         21177    21182    +5     
=========================================
+ Hits          18560    18565    +5     
  Misses         2617     2617           
Flag Coverage Δ
5-max 87.64% <100.00%> (+<0.01%) :arrow_up:
7.4 87.64% <100.00%> (+<0.01%) :arrow_up:
agnostic 67.03% <100.00%> (+<0.01%) :arrow_up:
mysql 68.82% <0.00%> (-0.04%) :arrow_down:
pgsql 68.84% <0.00%> (-0.04%) :arrow_down:
sqlite 66.66% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nerator/Behavior/Archivable/ArchivableBehavior.php 91.95% <100.00%> (+0.49%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.