Closed mringler closed 1 year ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 92.85714%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 88.44%. Comparing base (
12c23e1
) to head (1db89c3
). Report is 107 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/Propel/Runtime/Map/ColumnMap.php | 0.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do we have a way to update docs here accordingly, so it is clear what to expect and what support across the DB types has been achieved yet?
Do we have a way to update docs
Not sure, the only doc for Propel 2 that I know of is at http://propelorm.org/documentation/, but I am not really familiar with it
Right, we probably want to add UUID info at https://github.com/propelorm/propelorm.github.com then to be published after we merged.
Small conflict then we should be good to go
Oh, hadn't realized, thank you for the notice!
As discussed in #1914, this allows to use
UUID
as column type in schema.xml. Underlying columns are set to the native uuid type of the database system (uuid
in Postgres and Oracle,UNIQUEIDENTIFIER
in mssql). In Mysql/MariaDB and SQLite, an error is thrown. Inside the model and query classes, the uuid columns use string values.This is pretty straight forward, a new type literal is registered and associated with strings, and register the type in the vendor adapters with the corresponding type. For Postgres, I added cast statements used during migration. Tests check generated
create
andalter
statements and internal mapping of uuid to string.I have played around with it on Postgres, and it seems to work there.
I also added a commit with two fixes for the test setup scripts:
setup.mysql.sh
always used "test" as database name, even though the fixtures are build using an environment variable ($DB_NAME
) with "test" only as fallbacksetup.pgsql.sh
some statements failed when a variable was empty, leading to empty string parameters