propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Fix CS by removing inline assignments. #1946

Closed michbeck closed 1 year ago

michbeck commented 1 year ago

Follow of #1945 for #1921

dereuromark commented 1 year ago

The order in some cases cannot change Otherwise this creates Bugs. Some of this can be seen in current test fails, others might Fall through the Cracks of CI and code review

codecov-commenter commented 1 year ago

Codecov Report

Base: 88.69% // Head: 88.65% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (c530d59) compared to base (8aa4f2b). Patch coverage: 84.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1946 +/- ## ============================================ - Coverage 88.69% 88.65% -0.04% - Complexity 8002 8017 +15 ============================================ Files 243 243 Lines 24474 24542 +68 ============================================ + Hits 21706 21758 +52 - Misses 2768 2784 +16 ``` | Flag | Coverage Δ | | |---|---|---| | 5-max | `88.65% <84.66%> (-0.04%)` | :arrow_down: | | 7.4 | `88.65% <84.66%> (-0.04%)` | :arrow_down: | | agnostic | `67.44% <77.33%> (+0.01%)` | :arrow_up: | | mysql | `69.17% <40.66%> (-0.13%)` | :arrow_down: | | pgsql | `69.18% <42.00%> (-0.14%)` | :arrow_down: | | sqlite | `67.18% <40.66%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | Coverage Δ | | |---|---|---| | [...rc/Propel/Generator/Behavior/I18n/I18nBehavior.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQmVoYXZpb3IvSTE4bi9JMThuQmVoYXZpb3IucGhw) | `95.83% <ø> (ø)` | | | [src/Propel/Generator/Platform/MysqlPlatform.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUGxhdGZvcm0vTXlzcWxQbGF0Zm9ybS5waHA=) | `95.69% <ø> (ø)` | | | [src/Propel/Generator/Reverse/MysqlSchemaParser.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUmV2ZXJzZS9NeXNxbFNjaGVtYVBhcnNlci5waHA=) | `90.00% <ø> (ø)` | | | [src/Propel/Generator/Reverse/PgsqlSchemaParser.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUmV2ZXJzZS9QZ3NxbFNjaGVtYVBhcnNlci5waHA=) | `90.15% <ø> (-0.04%)` | :arrow_down: | | [src/Propel/Generator/Model/Diff/DatabaseDiff.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvRGlmZi9EYXRhYmFzZURpZmYucGhw) | `64.28% <32.25%> (-8.84%)` | :arrow_down: | | [...rator/Behavior/Versionable/VersionableBehavior.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQmVoYXZpb3IvVmVyc2lvbmFibGUvVmVyc2lvbmFibGVCZWhhdmlvci5waHA=) | `85.31% <83.33%> (-1.40%)` | :arrow_down: | | [src/Propel/Generator/Builder/Om/ObjectBuilder.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQnVpbGRlci9PbS9PYmplY3RCdWlsZGVyLnBocA==) | `93.86% <100.00%> (+<0.01%)` | :arrow_up: | | [...rc/Propel/Generator/Builder/Om/TableMapBuilder.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQnVpbGRlci9PbS9UYWJsZU1hcEJ1aWxkZXIucGhw) | `94.54% <100.00%> (+0.13%)` | :arrow_up: | | [src/Propel/Generator/Config/GeneratorConfig.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQ29uZmlnL0dlbmVyYXRvckNvbmZpZy5waHA=) | `97.11% <100.00%> (+0.02%)` | :arrow_up: | | [src/Propel/Generator/Model/Behavior.php](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvQmVoYXZpb3IucGhw) | `86.17% <100.00%> (+0.14%)` | :arrow_up: | | ... and [10 more](https://codecov.io/gh/propelorm/Propel2/pull/1946?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.