propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 393 forks source link

Fixes phpstan errors, set PHPStan to level 7 #1951

Closed michbeck closed 1 year ago

michbeck commented 1 year ago

PHP Stan fixes for #1921

codecov-commenter commented 1 year ago

Codecov Report

Base: 88.63% // Head: 88.56% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (c7661af) compared to base (5531e13). Patch coverage: 73.46% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1951 +/- ## ============================================ - Coverage 88.63% 88.56% -0.08% - Complexity 8019 8047 +28 ============================================ Files 243 243 Lines 24549 24592 +43 ============================================ + Hits 21759 21779 +20 - Misses 2790 2813 +23 ``` | Flag | Coverage Δ | | |---|---|---| | 5-max | `88.56% <73.46%> (-0.08%)` | :arrow_down: | | 7.4 | `88.56% <73.46%> (-0.08%)` | :arrow_down: | | agnostic | `67.30% <42.85%> (-0.10%)` | :arrow_down: | | mysql | `69.09% <55.78%> (-0.05%)` | :arrow_down: | | pgsql | `69.11% <50.34%> (-0.07%)` | :arrow_down: | | sqlite | `67.08% <49.65%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | Coverage Δ | | |---|---|---| | [.../Propel/Generator/Builder/Om/AbstractOMBuilder.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQnVpbGRlci9PbS9BYnN0cmFjdE9NQnVpbGRlci5waHA=) | `96.72% <0.00%> (ø)` | | | [src/Propel/Generator/Manager/ModelManager.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTWFuYWdlci9Nb2RlbE1hbmFnZXIucGhw) | `96.55% <ø> (ø)` | | | [src/Propel/Generator/Platform/PgsqlPlatform.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUGxhdGZvcm0vUGdzcWxQbGF0Zm9ybS5waHA=) | `97.56% <ø> (ø)` | | | [src/Propel/Generator/Reverse/PgsqlSchemaParser.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUmV2ZXJzZS9QZ3NxbFNjaGVtYVBhcnNlci5waHA=) | `87.54% <0.00%> (ø)` | | | [...c/Propel/Runtime/Collection/CollectionIterator.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9SdW50aW1lL0NvbGxlY3Rpb24vQ29sbGVjdGlvbkl0ZXJhdG9yLnBocA==) | `52.50% <ø> (ø)` | | | [src/Propel/Runtime/Collection/ObjectCollection.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9SdW50aW1lL0NvbGxlY3Rpb24vT2JqZWN0Q29sbGVjdGlvbi5waHA=) | `97.04% <ø> (ø)` | | | [src/Propel/Runtime/Formatter/OnDemandFormatter.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9SdW50aW1lL0Zvcm1hdHRlci9PbkRlbWFuZEZvcm1hdHRlci5waHA=) | `80.35% <0.00%> (-1.47%)` | :arrow_down: | | [src/Propel/Runtime/Map/DatabaseMap.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9SdW50aW1lL01hcC9EYXRhYmFzZU1hcC5waHA=) | `96.34% <ø> (ø)` | | | [src/Propel/Runtime/Util/PropelConditionalProxy.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9SdW50aW1lL1V0aWwvUHJvcGVsQ29uZGl0aW9uYWxQcm94eS5waHA=) | `100.00% <ø> (ø)` | | | [src/Propel/Generator/Platform/SqlitePlatform.php](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUGxhdGZvcm0vU3FsaXRlUGxhdGZvcm0ucGhw) | `92.96% <20.00%> (-1.11%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/propelorm/Propel2/pull/1951?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dereuromark commented 1 year ago

@mringler This would then be the last PR merged for the release of new beta this week Is this OK for you?

dereuromark commented 1 year ago

Nice work!

mringler commented 1 year ago

@mringler This would then be the last PR merged for the release of new beta this week Is this OK for you?

Awesome!

dereuromark commented 1 year ago

Also, only 981 errors more to go for level 8 then :P

michbeck commented 1 year ago

Also, only 981 errors more to go for level 8 then :P

Is this a note to be a volunteer? :P