search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Fixes phpstan errors, set PHPStan to level 7 #1951

Closed michbeck closed 1 year ago

michbeck commented 1 year ago

PHP Stan fixes for #1921

codecov-commenter commented 1 year ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.91667% with 39 lines in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (5531e13) to head (fc349a2). Report is 68 commits behind head on master.

Files with missing lines Patch % Lines
src/Propel/Generator/Reverse/PgsqlSchemaParser.php 0.00% 7 Missing :warning:
src/Propel/Generator/Manager/MigrationManager.php 75.00% 6 Missing :warning:
src/Propel/Generator/Platform/SqlitePlatform.php 20.00% 4 Missing :warning:
src/Propel/Generator/Reverse/MysqlSchemaParser.php 69.23% 4 Missing :warning:
src/Propel/Generator/Model/Domain.php 40.00% 3 Missing :warning:
src/Propel/Runtime/Adapter/Pdo/PgsqlAdapter.php 25.00% 3 Missing :warning:
.../Propel/Generator/Builder/Om/AbstractOMBuilder.php 50.00% 2 Missing :warning:
src/Propel/Generator/Command/InitCommand.php 50.00% 2 Missing :warning:
src/Propel/Generator/Manager/AbstractManager.php 60.00% 2 Missing :warning:
src/Propel/Generator/Manager/SqlManager.php 50.00% 1 Missing :warning:
... and 5 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1951 +/- ## ============================================ - Coverage 88.63% 88.56% -0.08% - Complexity 8019 8051 +32 ============================================ Files 243 243 Lines 24549 24592 +43 ============================================ + Hits 21759 21779 +20 - Misses 2790 2813 +23 ``` | [Flag](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | Coverage Δ | | |---|---|---| | [5-max](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `88.56% <72.91%> (-0.08%)` | :arrow_down: | | [7.4](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `88.56% <72.91%> (-0.08%)` | :arrow_down: | | [agnostic](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `67.30% <43.75%> (-0.10%)` | :arrow_down: | | [mysql](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `69.08% <53.47%> (-0.06%)` | :arrow_down: | | [pgsql](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `69.10% <47.91%> (-0.08%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/propelorm/Propel2/pull/1951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `67.07% <47.22%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dereuromark commented 1 year ago

@mringler This would then be the last PR merged for the release of new beta this week Is this OK for you?

dereuromark commented 1 year ago

Nice work!

mringler commented 1 year ago

@mringler This would then be the last PR merged for the release of new beta this week Is this OK for you?

Awesome!

dereuromark commented 1 year ago

Also, only 981 errors more to go for level 8 then :P

michbeck commented 1 year ago

Also, only 981 errors more to go for level 8 then :P

Is this a note to be a volunteer? :P