codecov-commenter
commented
1 year ago Codecov Report
Base: 88.63% // Head: 88.63% // No change to project coverage :thumbsup:
Coverage data is based on head (
76346ae) compared to base (5531e13). Patch coverage: 92.85% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1953 +/- ## ========================================= Coverage 88.63% 88.63% Complexity 8019 8019 ========================================= Files 243 243 Lines 24549 24549 ========================================= Hits 21759 21759 Misses 2790 2790 ``` | Flag | Coverage Δ | | |---|---|---| | 5-max | `88.63% <92.85%> (ø)` | | | 7.4 | `88.63% <92.85%> (ø)` | | | agnostic | `67.39% <67.85%> (ø)` | | | mysql | `69.13% <64.28%> (ø)` | | | pgsql | `69.17% <67.85%> (ø)` | | | sqlite | `67.15% <57.14%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | Coverage Δ | | |---|---|---| | [src/Propel/Generator/Model/Table.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvVGFibGUucGhw) | `90.56% <50.00%> (ø)` | | | [src/Propel/Runtime/Map/ColumnMap.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9SdW50aW1lL01hcC9Db2x1bW5NYXAucGhw) | `77.16% <75.00%> (ø)` | | | [...ltipleColumns/AggregateMultipleColumnsBehavior.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQmVoYXZpb3IvQWdncmVnYXRlTXVsdGlwbGVDb2x1bW5zL0FnZ3JlZ2F0ZU11bHRpcGxlQ29sdW1uc0JlaGF2aW9yLnBocA==) | `96.18% <100.00%> (ø)` | | | [src/Propel/Generator/Builder/Om/QueryBuilder.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvQnVpbGRlci9PbS9RdWVyeUJ1aWxkZXIucGhw) | `91.32% <100.00%> (ø)` | | | [src/Propel/Generator/Model/Column.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvQ29sdW1uLnBocA==) | `95.96% <100.00%> (ø)` | | | [src/Propel/Generator/Model/Database.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvRGF0YWJhc2UucGhw) | `72.78% <100.00%> (ø)` | | | [src/Propel/Generator/Model/Domain.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvRG9tYWluLnBocA==) | `84.48% <100.00%> (ø)` | | | [src/Propel/Generator/Model/Index.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvTW9kZWwvSW5kZXgucGhw) | `97.84% <100.00%> (ø)` | | | [src/Propel/Generator/Platform/DefaultPlatform.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUGxhdGZvcm0vRGVmYXVsdFBsYXRmb3JtLnBocA==) | `94.60% <100.00%> (ø)` | | | [src/Propel/Generator/Platform/MysqlPlatform.php](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#diff-c3JjL1Byb3BlbC9HZW5lcmF0b3IvUGxhdGZvcm0vTXlzcWxQbGF0Zm9ybS5waHA=) | `95.69% <100.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/propelorm/Propel2/pull/1953?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Now that we are using more string types, the type going into those is usually quite clear. This makes it a bit faster but more importantly avoids false positive comparison in some cases where casting would create wrong results.
Follow https://github.com/propelorm/Propel2/pull/1951