Closed michbeck closed 1 year ago
The other changes look good to me.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 79.48718%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 89.27%. Comparing base (
011aaa7
) to head (e6f2a49
). Report is 61 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mringler @dereuromark can we move forward here?
@michbeck It looks like @dereuromark has left the project, and it looks like there is no successor at Spryker at the moment. I have contacted the owner, and he told me that the project will keep being maintained by Spryker, but I haven't heard back if/when there will be someone who actively maintains Propel2, i.e. merges this PRs. For what it's worth, I am very sorry for the situation! I really appreciate the work you put into this in the previous PRs, and I would have really liked to see this merged, preferably in acceptable time. I guess when/if someone takes over, contributors like you and I can decide if they want to come back. Best wishes
@mringler thank you for the reminder and your patience! ❤️ I really hope you'll keep contributing after this, I'm really sorry that you had to wait, I know from personal experience that it is frustrating when your contributions won't move forward. 😞
I'll take this over temporarely until I figure out who will be our new internal owner. Your PR looks good to me! 💪 There is just one comment from Mark, to which I agree, that needs to be fixed but we could do that as well.
@michbeck can you maybe take care of it tomorrow? I'll approve the merge as soon as this has been fixed by someone and I've got the required permissions for this repository.
@gechetspr this is ready for merge now.
Road to level 8