Closed Mau04 closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
4f36eea
) 89.27% compared to head (9ddf3c9
) 89.27%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Mau04 It looks like the old maintainer of Propel2, @dereuromark, has left the project, and it looks like there is no successor at Spryker at the moment. I have contacted the owner, and he told me that the project will keep being maintained by Spryker, but I haven't heard back if/when there will be someone who actively maintains Propel2, i.e. merges this PRs. For what it's worth, I am very sorry for the situation! This should have been merged month ago, with all the thanks and commendations that are in order. I found getting acquainted with Propel and creating a PR takes effort, and I wish your first contribution to the project had been a more rewarding experience. I guess when/if someone takes over, contributors like you and I can decide if they want to come back. Best wishes
Hello @mringler & @Mau04 Community contributions are the backbone of Propel, and Spryker aims to play a supportive role in enhancing this ecosystem. We're actively looking for core contributors while improving our own support levels. Expect quicker, more impactful responses to PRs and contributions going forward, as we are ramping up the developer effort on the open PRs in the repository.
Thank you for your vital role in this community. We're excited for more collaborative achievements
This PR adds support for
defaultExpr="CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP"
for MySQL as requested in #1203. Previously, a migration would always contain an ALTER Statement to setON UPDATE CURRENT_TIMESTAMP
although it is already like that in the database. The root cause was that theExtra
part was not checked in theMysqlSchemaParser
class.