Closed mringler closed 1 year ago
Patch coverage has no change and project coverage change: -1.51
:warning:
Comparison is base (
011aaa7
) 88.56% compared to head (d2607c2
) 87.05%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'll get this merged, it makes sense.
With the current Symfony components, one test in the 5-max and and 6-max group fails, see for example this run.
Apparently, the Symfony PropertyInfo has changed internally, and now an assertion fails. A comment in the test acknowledges that it tests Symfony internals:
Examining
$fictionMetadatas
, I can see that bothValidateTriggerFiction
andValidateTriggerBook
are present in$fictionMetadatas[0].constraintsByGroup
:This is also successfully tested in the rest of the test case.
So apparently the PropertyInfo component now groups those constraints in the same PropertyMetadata object instead of using a new object for each. But this does not concern Propel. So we can just remove that assertion. We could also turn it into
assertNotEmpty()
, but that is tested implicitly in the next assertion.